feat: Update system user form fields translations #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
6 tasks
Siyasanga
force-pushed
the
ocrvs-6830
branch
3 times, most recently
from
c3f17a1
to
9537827
Compare
Remove the question that asks the user for a national ID number in the User details form as it is not required opencrvs/opencrvs-core#6830
The tranlation also get used views/form.ts file which is a different form config file opencrvs/opencrvs-core#6830
Since the object was to remove the EN suffix, doing that for this key would conflict with the already existing 'form.field.label.firstName' so to differentiate, I opted to use 'form.field.label.userFirstName' to associate it with the user form opencrvs/opencrvs-core#6830
Siyasanga
changed the title
Siyasanga
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A request came for the clients to change the labels for "First name(s)" to "User's first name". Also change "Last name" to "User's surname" for clarity and less confussion.
opencrvs/opencrvs-core#6830